Change in vdsm[master]: jsonrpc: ignore unknown message id

danken at redhat.com danken at redhat.com
Wed Oct 14 13:20:36 UTC 2015


Dan Kenigsberg has submitted this change and it was merged.

Change subject: jsonrpc: ignore unknown message id
......................................................................


jsonrpc: ignore unknown message id

When we received jsonrpc request which is missing an id we need to make sure
that we are able to ignore it without blowing up. Current client code base
will make sure that requests have ids at all times but we need to cover edge
cases like this since we have mini broker capabilities and any client could be
used.


Change-Id: Ide306f44c8c42d6661932698307efa4ce163e90e
Signed-off-by: pkliczewski <piotr.kliczewski at gmail.com>
Reviewed-on: https://gerrit.ovirt.org/43746
Continuous-Integration: Jenkins CI
Reviewed-by: Yaniv Bronhaim <ybronhei at redhat.com>
Reviewed-by: Francesco Romani <fromani at redhat.com>
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M lib/yajsonrpc/__init__.py
1 file changed, 7 insertions(+), 1 deletion(-)

Approvals:
  Piotr Kliczewski: Verified
  Yaniv Bronhaim: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved
  Francesco Romani: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/43746
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ide306f44c8c42d6661932698307efa4ce163e90e
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dmitrykuzn at gmail.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org


More information about the vdsm-patches mailing list