Change in vdsm[master]: vm: small cleanup of _completeIncomingMigration()

mbetak at redhat.com mbetak at redhat.com
Wed Oct 14 11:09:19 UTC 2015


Martin Betak has posted comments on this change.

Change subject: vm: small cleanup of _completeIncomingMigration()
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/47086/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 2752:             fromSnapshot = self.conf.pop('restoreFromSnapshot', False)
Line 2753:             hooks.after_vm_dehibernate(self._dom.XMLDesc(0), self.conf,
Line 2754:                                        {'FROM_SNAPSHOT': fromSnapshot})
Line 2755:         elif 'migrationDest' in self.conf:
Line 2756:             if not self._checkMigrationCompletedDuringRecovery():
> let's find a better (= more expressive) name
Done
Line 2757:                 usedTimeout = self._waitForUnderlyingMigration()
Line 2758:                 self._attachLibvirtDomainAfterMigration(
Line 2759:                     self._incomingMigrationFinished.isSet(), usedTimeout)
Line 2760:             # else domain connection already established earlier


-- 
To view, visit https://gerrit.ovirt.org/47086
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia1afb406e3e2ca7b37a621fc1bcc8bc1bf37031b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list