Change in vdsm[master]: ssl: runtime config to choose implementation

piotr.kliczewski at gmail.com piotr.kliczewski at gmail.com
Tue Oct 13 11:42:17 UTC 2015


Piotr Kliczewski has posted comments on this change.

Change subject: ssl: runtime config to choose implementation
......................................................................


Patch Set 16:

(2 comments)

https://gerrit.ovirt.org/#/c/44689/16/debian/rules
File debian/rules:

Line 33: 		SERVICE_PATH=/usr/sbin/service
Line 34: 
Line 35: override_dh_auto_build:
Line 36: 		sed -i -e 's/@SSl_IMPLEMENTATION@/ssl/g' lib/vdsm/config.py
Line 37: 		dh_auto_build
> so why to have the flag at all?
The flag is here to help us. We can use configure to define which implementation we want to use for fedora/centos. Once the flag is set during build process we test our ssl code using one or the other ssl implementation. Without the flag we would need to make sure that when we build vdsm we test using both implementations which would complicate test code significantly.
Line 38: 
Line 39: destdir = debian/tmp
Line 40: 
Line 41: override_dh_auto_install:


https://gerrit.ovirt.org/#/c/44689/16/vdsm.spec.in
File vdsm.spec.in:

Line 628: sed -i -e 's/^software_version =.*/software_version = "'"${baseversion}"'"/' \
Line 629:        -e 's/^raw_version_revision =.*/raw_version_revision = "'"${rawversion}"'"/' \
Line 630:        -e 's/^software_revision =.*/software_revision = "'"${baserelease}"'"/' vdsm/dsaversion.py
Line 631: 
Line 632: sed -i -e 's/@SSl_IMPLEMENTATION@/%{ssl_implementation}/g' lib/vdsm/config.py
> also any additional flag that user can not be aware about- just keep fedora
As you can see m2c is default for fedora but you can choose during the build/runtime to use ssl.
Line 633: 
Line 634: %install
Line 635: rm -rf %{buildroot}
Line 636: make DESTDIR=%{buildroot} install


-- 
To view, visit https://gerrit.ovirt.org/44689
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9881d11e30ced9c34bfe602bba3d968f57e0fe15
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list