Change in vdsm[master]: vdsm: introduce cpuinfo module

mpolednik at redhat.com mpolednik at redhat.com
Tue Oct 13 10:45:28 UTC 2015


Martin Polednik has posted comments on this change.

Change subject: vdsm: introduce cpuinfo module
......................................................................


Patch Set 9:

(3 comments)

https://gerrit.ovirt.org/#/c/46912/9/lib/vdsm/cpuinfo.py
File lib/vdsm/cpuinfo.py:

Line 38:     'ppc64le': Architecture.PPC64LE
Line 39: }
Line 40: 
Line 41: _ARCHITECTURE_TO_CPU_MAP = {
Line 42:     Architecture.X86_64: 'x86',
> x86_64?
no, libvirt treats x86_64 as x86
Line 43:     Architecture.PPC64: 'ppc64',
Line 44:     Architecture.PPC64LE: 'ppc64',
Line 45: }
Line 46: 


Line 40: 
Line 41: _ARCHITECTURE_TO_CPU_MAP = {
Line 42:     Architecture.X86_64: 'x86',
Line 43:     Architecture.PPC64: 'ppc64',
Line 44:     Architecture.PPC64LE: 'ppc64',
> ppc64le?
same as above - libvirt naming
Line 45: }
Line 46: 
Line 47: _CPUS = defaultdict(dict)
Line 48: 


Line 98:             except ValueError:
Line 99:                 continue
Line 100:             if key == 'processor':
Line 101:                 cpu = int(value)
Line 102:                 continue
> Instead of converting the "processor" key and treating it as the key for a 
This logic is taken from caps mostly as is, but I'll try to work these suggestions in.
Line 103:             else:
Line 104:                 _CPUS[cpu][key] = value
Line 105: 
Line 106: # Parse the cpuinfo right when module loads


-- 
To view, visit https://gerrit.ovirt.org/46912
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa702b05f3825ebdcfed16d86d39a8c38fcf224c
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list