Change in vdsm[ovirt-3.6]: virt: Don't warn about unknown type for channel devices
vfeenstr at redhat.com
vfeenstr at redhat.com
Mon Oct 12 12:30:09 UTC 2015
Hello Francesco Romani, Martin Polednik,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/47221
to review the following change.
Change subject: virt: Don't warn about unknown type for channel devices
......................................................................
virt: Don't warn about unknown type for channel devices
We're currently issuing warnings in the VDSM logs for channel devices:
Thread-38551::WARNING::2014-08-07
08:40:26,595::vm::2059::vm.Vm::(buildConfDevices)
vmId=`97ca14a3-1502-4ac6-bb48-ba9dcd8179d2`::Unknown type found, device:
'{'device': 'unix', 'alias': 'channel0', 'type': 'channel', 'address': {'bus':
'0', 'controller': '0', 'type': 'virtio-serial', 'port': '1'}}' found
These warnings are not supposed to be issues as we do just do not maintain
them. This patch changes this to not warn in those cases.
Backport-To: 3.6
Change-Id: Id391770f9f51a9190035f71a3487271d4062fa67
Bug-Url: https://bugzilla.redhat.com/1128881
Signed-off-by: Vinzenz Feenstra <vfeenstr at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/46788
Continuous-Integration: Jenkins CI
Reviewed-by: Martin Polednik <mpolednik at redhat.com>
Reviewed-by: Francesco Romani <fromani at redhat.com>
---
M vdsm/virt/vm.py
1 file changed, 3 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/21/47221/1
diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index 06a19b7..24304a2 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -465,8 +465,9 @@
try:
devices[dev['type']].append(dev)
except KeyError:
- self.log.warn("Unknown type found, device: '%s' "
- "found", dev)
+ if 'type' not in dev or dev['type'] != 'channel':
+ self.log.warn("Unknown type found, device: '%s' "
+ "found", dev)
devices[hwclass.GENERAL].append(dev)
if not devices[hwclass.GRAPHICS]:
--
To view, visit https://gerrit.ovirt.org/47221
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id391770f9f51a9190035f71a3487271d4062fa67
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
More information about the vdsm-patches
mailing list