Change in vdsm[master]: ssl: configurable implementation

ybronhei at redhat.com ybronhei at redhat.com
Mon Oct 12 11:10:50 UTC 2015


Yaniv Bronhaim has posted comments on this change.

Change subject: ssl: configurable implementation
......................................................................


Patch Set 16:

(2 comments)

https://gerrit.ovirt.org/#/c/44494/16/lib/vdsm/sslcompat.py
File lib/vdsm/sslcompat.py:

Line 16: # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
Line 17: #
Line 18: # Refer to the README and COPYING files for full details of the license
Line 19: #
Line 20: try:
> This patch is interim step and the change that you propose is in the next p
I also don't see a reason for two patches.. it can be done in one single and simple patch. having new config value, having the compact trick and fix the imports.
Line 21:     from . import m2cutils as sslutils
Line 22:     from .m2cutils import SSLHandshakeDispatcher
Line 23:     from .m2cutils import SSLSocket
Line 24: except ImportError:


https://gerrit.ovirt.org/#/c/44494/16/vdsm.spec.in
File vdsm.spec.in:

Line 42: %global _polkitdir %{_localstatedir}/lib/polkit-1/localauthority/10-vendor.d
Line 43: %endif
Line 44: 
Line 45: # enable m2crypto by default
Line 46: %global with_m2c 1
> We can't required it always. We could have it in debian as well but please 
first of all - this is a spec, spec is for fedora only, and we will always want m2c here. how does it make anything simple?
second, as I said before - if users run it over debian, they must be aware that they need to change vdsm.conf for that. which should do the magic
Line 47: 
Line 48: # Gluster should not be shipped with RHEV
Line 49: %if ! 0%{?rhev_build}
Line 50: %global with_gluster 1


-- 
To view, visit https://gerrit.ovirt.org/44494
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6501981bbd5276c49731b0d9eba4794286b0f823
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list