Change in vdsm[ovirt-3.5]: takset: fix taskset and tests on python 2.6
nsoffer at redhat.com
nsoffer at redhat.com
Mon Oct 12 07:50:47 UTC 2015
Nir Soffer has posted comments on this change.
Change subject: takset: fix taskset and tests on python 2.6
......................................................................
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/47013/4/tests/tasksetTests.py
File tests/tasksetTests.py:
Line 120: [7, 3],
Line 121: [127, 7],
Line 122: [129, 8],
Line 123: [65535, 16],
Line 124: [73458, 17],
Why global? this is used by one test, should be inlined in the tests @permutations.
Also, why do we need all these value?
Do we miss anything in these permutations?
@permutations([(0, 0), (1, 1), (-1, 1), (37, 6), (-37, 6)])
def test_length(value, result):
self.assertEqual(taskset._bit_length(value), result)
Line 125: ]
Line 126:
Line 127:
Line 128: @expandPermutations
--
To view, visit https://gerrit.ovirt.org/47013
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7621a1443367bfead7b953df5218dea24bf8095a
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list