Change in vdsm[master]: utils: split out execCmd wrapping logic

danken at redhat.com danken at redhat.com
Sun Oct 11 16:25:59 UTC 2015


Dan Kenigsberg has submitted this change and it was merged.

Change subject: utils: split out execCmd wrapping logic
......................................................................


utils: split out execCmd wrapping logic

The execCmd utility contains fairly intricate logic which wraps a given
command with various other utilities (eg. sudo, nice, taskset, etc)
according to the callers preferences.  We should split this logic into
its own function so that other direct consumers of CPopen (eg. qemuimg
in an upcoming patch) can get the same semantics as execCmd.

Change-Id: I98a01c4e8c80202b8e897dacc7628504d3cf7771
Signed-off-by: Adam Litke <alitke at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/47107
Reviewed-by: Nir Soffer <nsoffer at redhat.com>
Continuous-Integration: Jenkins CI
Reviewed-by: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M lib/vdsm/cmdutils.py
M lib/vdsm/utils.py
M tests/utilsTests.py
3 files changed, 42 insertions(+), 30 deletions(-)

Approvals:
  Piotr Kliczewski: Looks good to me, but someone else must approve
  Adam Litke: Verified
  Nir Soffer: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/47107
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I98a01c4e8c80202b8e897dacc7628504d3cf7771
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: automation at ovirt.org


More information about the vdsm-patches mailing list