Change in vdsm[master]: networkTests: normalize strings (to unicode) through json magic

danken at redhat.com danken at redhat.com
Sun Oct 11 09:23:10 UTC 2015


Dan Kenigsberg has submitted this change and it was merged.

Change subject: networkTests: normalize strings (to unicode) through json magic
......................................................................


networkTests: normalize strings (to unicode) through json magic

To make it easier to read differences between "running config"
and "kernel config" (the state of networking) the strings
contained in dictionaries must not be stored randomly as str
or unicode instances.

This patch converts all strings to unicode. Thanks to Ido Barkan
for a neat trick using the json library.

Change-Id: I6362e04189f134ad27ee4e3c1991020b2eee91aa
Signed-off-by: Ondřej Svoboda <osvoboda at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/45201
Continuous-Integration: Jenkins CI
Reviewed-by: Ido Barkan <ibarkan at redhat.com>
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M lib/vdsm/netconfpersistence.py
M tests/functional/networkTests.py
2 files changed, 18 insertions(+), 8 deletions(-)

Approvals:
  Ido Barkan: Looks good to me, but someone else must approve
  Ondřej Svoboda: Verified
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/45201
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6362e04189f134ad27ee4e3c1991020b2eee91aa
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org


More information about the vdsm-patches mailing list