Change in vdsm[master]: storage: Initial size for thin provisioning disk

nsoffer at redhat.com nsoffer at redhat.com
Fri Oct 9 21:05:20 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: storage: Initial size for thin provisioning disk
......................................................................


Patch Set 4:

(1 comment)

https://gerrit.ovirt.org/#/c/46417/4/tests/blockVolumeTests.py
File tests/blockVolumeTests.py:

Line 35:         (volume.PREALLOCATED_VOL, 0, None, "0"),
Line 36:         (volume.PREALLOCATED_VOL, 2048, None, "1"),
Line 37:         (volume.PREALLOCATED_VOL, 2049, None, "2"),
Line 38:         (volume.PREALLOCATED_VOL, 2097152, None, "1024"),
Line 39:         (volume.PREALLOCATED_VOL, 2049, 2048, "2"),
> In that case, I'd prefer to always fail if the combination of parameters do
I'm fine with failing in all cases.

Fred, can you replace the warnings with the proper exception (InvalidParameterException?)
Line 40:         (volume.SPARSE_VOL, 9999, None,
Line 41:          config.get("irs", "volume_utilization_chunk_mb")),
Line 42:         (volume.SPARSE_VOL, 8388608, 2097152, "%s" % int(1024*1.1)),
Line 43:         (volume.SPARSE_VOL, 8388608, 2097153, "%s" % int(1025*1.1)),


-- 
To view, visit https://gerrit.ovirt.org/46417
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaf5f142541bf0b311a77a0544a1c4ffb689a9fde
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Fred Rolland <frolland at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list