Change in vdsm[master]: storage: Initial size for thin provisioning disk
frolland at redhat.com
frolland at redhat.com
Thu Oct 8 10:25:04 UTC 2015
Freddy Rolland has posted comments on this change.
Change subject: storage: Initial size for thin provisioning disk
......................................................................
Patch Set 5:
(7 comments)
https://gerrit.ovirt.org/#/c/46417/5/client/vdsClient.py
File client/vdsClient.py:
Line 1062: sdUUID = args[0]
Line 1063: spUUID = args[1]
Line 1064: imgUUID = args[2]
Line 1065: diskSize = int(args[3])
Line 1066: convertFactor = 2097152 # number of blocks in 1G
> Wouldn't it be nicer as:
Done
Line 1067: size = diskSize * convertFactor
Line 1068: volFormat = int(args[4])
Line 1069: preallocate = int(args[5])
Line 1070: diskType = int(args[6])
Line 1080: srcVolUUID = BLANK_UUID
Line 1081: params = [sdUUID, spUUID, imgUUID, size, volFormat, preallocate,
Line 1082: diskType, newVol, descr, srcImgUUID, srcVolUUID]
Line 1083: if len(args) > 11:
Line 1084: params.append(int(args[11]) * convertFactor) # initialSize
> It would be more clear and consistent with the other code like this:
Done
Line 1085:
Line 1086: image = self.s.createVolume(*params)
Line 1087:
Line 1088: if image['status']['code']:
https://gerrit.ovirt.org/#/c/46417/5/vdsm/rpc/vdsmapi-schema.json
File vdsm/rpc/vdsmapi-schema.json:
Line 8268
Line 8269
Line 8270
Line 8271
Line 8272
> Document that value that unit is bytes if sent as string and sectors if sen
Done
Line 8283: # @srcImgUUID: If specified, create a snapshot from this Image
Line 8284: #
Line 8285: # @srcVolUUID: If specified, create a snapshot from this Volume
Line 8286: #
Line 8287: # @initialSize: #optional if specified, initial size in sectors
> Document that value that unit is bytes if sent as string and sectors if sen
Done
Line 8288: # of volume for thin provisioning on block storage.
Line 8289: # When using preallocated volumes or for file storage
Line 8290: # the initial size is ignored.
Line 8291: # (new in version 4.17.8)
https://gerrit.ovirt.org/#/c/46417/5/vdsm/storage/blockVolume.py
File vdsm/storage/blockVolume.py:
Line 163:
Line 164: return (dom.sdUUID, slot)
Line 165:
Line 166: @classmethod
Line 167: def _calculate_volume_alloc_size(cls, preallocate, capacity, initial_size):
> Document that capacity and initial_size are in sectors
Done
Line 168: if initial_size:
Line 169: if initial_size > capacity:
Line 170: log.error("The volume size %s is smaller "
Line 171: "than the requested initial size %s",
Line 165:
Line 166: @classmethod
Line 167: def _calculate_volume_alloc_size(cls, preallocate, capacity, initial_size):
Line 168: if initial_size:
Line 169: if initial_size > capacity:
> Use:
Done
Line 170: log.error("The volume size %s is smaller "
Line 171: "than the requested initial size %s",
Line 172: capacity, initial_size)
Line 173: raise se.InvalidParameterException("initial size",
Line 178: initial_size = int(initial_size * QCOW_OVERHEAD_FACTOR)
Line 179: vol_size_mb = ((initial_size + SECTORS_TO_MB - 1)
Line 180: / SECTORS_TO_MB)
Line 181: else:
Line 182: vol_size_mb = config.get("irs",
> config.getint
Done
Line 183: "volume_utilization_chunk_mb")
Line 184: else:
Line 185: vol_size_mb = (capacity + SECTORS_TO_MB - 1) / SECTORS_TO_MB
Line 186:
--
To view, visit https://gerrit.ovirt.org/46417
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaf5f142541bf0b311a77a0544a1c4ffb689a9fde
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Fred Rolland <frolland at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list