Change in vdsm[master]: netinfo: stop using getVlanID() in network.api

osvoboda at redhat.com osvoboda at redhat.com
Thu Oct 8 10:14:23 UTC 2015


Ondřej Svoboda has posted comments on this change.

Change subject: netinfo: stop using getVlanID() in network.api
......................................................................


Patch Set 4:

(1 comment)

https://gerrit.ovirt.org/#/c/46741/4/vdsm/network/api.py
File vdsm/network/api.py:

Line 153: tag
> I would raise an exception instead of an assertion with a message that serv
OK, I think it's a good idea to protect ourselves in this internal API.


-- 
To view, visit https://gerrit.ovirt.org/46741
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic473f3fbb0d7add34dca338d2b02f4d4d9ed47b0
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list