Change in vdsm[master]: qemuimg: add support for convert progress
alitke at redhat.com
alitke at redhat.com
Wed Oct 7 19:48:30 UTC 2015
Adam Litke has posted comments on this change.
Change subject: qemuimg: add support for convert progress
......................................................................
Patch Set 9:
(4 comments)
https://gerrit.ovirt.org/#/c/33910/9/vdsm/storage/image.py
File vdsm/storage/image.py:
Line 110:
Line 111: def __init__(self, repoPath):
Line 112: self.repoPath = repoPath
Line 113:
Line 114: def _qemuTaskProgressWait(self, command):
> Lets rename this to _wait_for_qemuimg_operation(self, op)
Done
Line 115: self.log.debug('waiting for qemu-img operation to complete')
Line 116:
Line 117: def abortImgConversion():
Line 118: self.log.info('aborting ongoing qemu-img operation')
Line 113:
Line 114: def _qemuTaskProgressWait(self, command):
Line 115: self.log.debug('waiting for qemu-img operation to complete')
Line 116:
Line 117: def abortImgConversion():
> We don't need this inline function, we can use command.abort directly.
Done
Line 118: self.log.info('aborting ongoing qemu-img operation')
Line 119: command.terminate()
Line 120:
Line 121: with vars.task.abort_callback(abortImgConversion):
Line 117: def abortImgConversion():
Line 118: self.log.info('aborting ongoing qemu-img operation')
Line 119: command.terminate()
Line 120:
Line 121: with vars.task.abort_callback(abortImgConversion):
> Use
Done
Line 122: while not command.finished:
Line 123: command.wait(self._QEMU_LOGGING_INTERVAL)
Line 124: self.log.debug('qemu-img operation progress: %s%%',
Line 125: command.progress)
Line 458: else:
Line 459: backing = None
Line 460: backingFormat = None
Line 461:
Line 462: qemucmd = qemuimg.convert(
> Lets call this "operation" or "op"
Done
Line 463: srcVol.getVolumePath(),
Line 464: dstVol.getVolumePath(),
Line 465: srcFormat=srcFormat,
Line 466: dstFormat=dstFormat,
--
To view, visit https://gerrit.ovirt.org/33910
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id0b53e418c62bb2e91444ba5f351c916ca417299
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list