Change in vdsm[master]: host stats: Add cpusStatus to vdsStats

rmohr at redhat.com rmohr at redhat.com
Wed Oct 7 09:31:42 UTC 2015


Roman Mohr has posted comments on this change.

Change subject: host stats: Add cpusStatus to vdsStats
......................................................................


Patch Set 7:

(1 comment)

https://gerrit.ovirt.org/#/c/46270/7/vdsm/virt/sampling.py
File vdsm/virt/sampling.py:

Line 687:     corresponds to the CPU index.
Line 688: 
Line 689:     :return list like [True, True, False, False, True]
Line 690:     """
Line 691:     return libvirtconnection.get().getCPUMap()[1]
> Two issues:
> Typically we poll state regularly and report cached values, which solve both issues.

You are right. I should poll and cache it separately. Will change the code

> Last, do we plan to return more info about cpus in the future?

None that I am aware of, but adding new entries to cpuStatistics is not an issue, just not having all there is a problem.
Line 692: 
Line 693: 
Line 694: def _get_cpu_core_stats(first_sample, last_sample):
Line 695:     interval = last_sample.timestamp - first_sample.timestamp


-- 
To view, visit https://gerrit.ovirt.org/46270
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I73c92f563c7c3e8ffbbcf639eba27fbe55389994
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Roman Mohr <rmohr at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list