Change in vdsm[master]: host stats: Collect stats from online cpu cores only

rmohr at redhat.com rmohr at redhat.com
Wed Oct 7 08:44:03 UTC 2015


Roman Mohr has posted comments on this change.

Change subject: host stats: Collect stats from online cpu cores only
......................................................................


Patch Set 7:

(1 comment)

https://gerrit.ovirt.org/#/c/46269/7//COMMIT_MSG
Commit Message:

Line 57:                                'cpuSys': '1.40',
Line 58:                                'cpuUser': '7.86',
Line 59:                                'nodeIndex': 0}
Line 60:                         }
Line 61:         [...]
> And what happens when cpu was offline before libvirtd started, and it goes 
> And what happens when cpu was offline before libvirtd started, and it goes online after that?

It will not be reported until libvirt is restarted. But even if they would, it would not be a problem.

> Vdsm will report now a new cpu to engine - does it break old engines?

Neither the changed count of online cpus , nor new cpu statistics would break the engine. Only reporting partially filled statistics would break old engines. After the statistics are parsed, they are just displayed in numa widgets in the frontend.
Line 62: 
Line 63: Change-Id: Ia9c247f9138e02a9230a0849a04cb2e1705e7fac


-- 
To view, visit https://gerrit.ovirt.org/46269
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia9c247f9138e02a9230a0849a04cb2e1705e7fac
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Roman Mohr <rmohr at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list