Change in vdsm[master]: net: tests: additional tests for host QOS

ibarkan at redhat.com ibarkan at redhat.com
Wed Oct 7 08:17:42 UTC 2015


Ido Barkan has posted comments on this change.

Change subject: net: tests: additional tests for host QOS
......................................................................


Patch Set 7:

(9 comments)

https://gerrit.ovirt.org/#/c/44699/7//COMMIT_MSG
Commit Message:

Line 9: top most
> topmost
Done


Line 9: Those test
> These tests
Done


https://gerrit.ovirt.org/#/c/44699/7/tests/nettestlib.py
File tests/nettestlib.py:

Line 98: IPRoute2Error
> My concern was that if the exception swallowing was merged (which by itself
removed


Line 109: addDevice
> yes, we should move to pep8_names, but here we inherit from Interface, so t
yup...


Line 126:     try:
Line 127:         yield vlan
Line 128:     finally:
Line 129:         try:
Line 130:             vlan.delDevice()
> here, too, I don't understand the exception catching.
if the underlying device was removed beforehand, the vlan device would be gone by now (added a comment).
Line 131:         except IPRoute2Error:
Line 132:             pass
Line 133: 
Line 134: 


https://gerrit.ovirt.org/#/c/44699/7/tests/tcTests.py
File tests/tcTests.py:

Line 390: analise
> analyse
Done


Line 405: xrange
> xrange is be gone in Python 3, range will suffice here.
Done


Line 420: vlan
> vlans
Done


Line 421: 16
> Explicit tag=16 fits here nicely.
Done


-- 
To view, visit https://gerrit.ovirt.org/44699
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibad639a9ad04593cfd477f60a8272614f3446522
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list