Change in vdsm[master]: ssl: runtime config to choose implementation

nsoffer at redhat.com nsoffer at redhat.com
Tue Oct 6 01:42:19 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: ssl: runtime config to choose implementation
......................................................................


Patch Set 14:

(1 comment)

https://gerrit.ovirt.org/#/c/44689/14/vdsm.spec.in
File vdsm.spec.in:

Line 628: sed -i -e 's/^software_version =.*/software_version = "'"${baseversion}"'"/' \
Line 629:        -e 's/^raw_version_revision =.*/raw_version_revision = "'"${rawversion}"'"/' \
Line 630:        -e 's/^software_revision =.*/software_revision = "'"${baserelease}"'"/' vdsm/dsaversion.py
Line 631: 
Line 632: sed -i -e 's/@SSl_IMPLEMENTATION@/%{ssl_implementation}/g' lib/vdsm/config.py
This should done via autoconf, modifying config.py.in.

We should have a way to configure ssl implemenation during configure, and the value you configure should be use in the code.

./configure --ssl-implemenation m2c should fail on debian and succeed on el/fc.

The configured value should be the default in config.py.in.

Users on el/fc will be able to change the default.

This is how all other configuration is done, why not use the same way to configure everything?
Line 633: 
Line 634: %install
Line 635: rm -rf %{buildroot}
Line 636: make DESTDIR=%{buildroot} install


-- 
To view, visit https://gerrit.ovirt.org/44689
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9881d11e30ced9c34bfe602bba3d968f57e0fe15
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list