Change in vdsm[master]: sampling: add 'ncpus' property to HostSample

rmohr at redhat.com rmohr at redhat.com
Mon Oct 5 13:26:54 UTC 2015


Roman Mohr has posted comments on this change.

Change subject: sampling: add 'ncpus' property to HostSample
......................................................................


Patch Set 13:

(1 comment)

https://gerrit.ovirt.org/#/c/42035/13/vdsm/virt/sampling.py
File vdsm/virt/sampling.py:

Line 555: self._ncpus = max(os.sysconf('SC_NPROCESSORS_ONLN'), 1)
> nice idea, but also change in behaviour. Which is probably a good thing, be
I guess even more correct, would be to store the number of CPUs always when the sample is collected, with the creation of HostStats. But we would also have to adjust our formula in hoststats then because the samples could then have different cpu counts.


-- 
To view, visit https://gerrit.ovirt.org/42035
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0e7d549b7772e3f38eec2dd9b91bbc6416b549bf
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list