Change in vdsm[master]: migration: Add incoming migration semaphore

mbetak at redhat.com mbetak at redhat.com
Mon Oct 5 10:43:20 UTC 2015


Martin Betak has posted comments on this change.

Change subject: migration: Add incoming migration semaphore
......................................................................


Patch Set 3:

(2 comments)

https://gerrit.ovirt.org/#/c/45954/3/vdsm/virt/migration.py
File vdsm/virt/migration.py:

Line 56: 
Line 57: mig = min(config.getint('vars', 'max_incoming_migrations'),
Line 58:           caps.CpuTopology().cores())
Line 59: 
Line 60: incomingMigrations = threading.BoundedSemaphore(mig)
> let's avoid this temporary, please.
Done
Line 61: 
Line 62: 
Line 63: class MigrationDestinationSetupError(RuntimeError):
Line 64:     """


Line 342:                 startTime += destCreationTime
Line 343:                 self.log.info('Creation of destination VM took: %d seconds',
Line 344:                               destCreationTime)
Line 345: 
Line 346:                 if result['status'] == errCode['migrationLimit']['status']:
> please consider use (and probably enhance) response.is_error.
Done
Line 347:                     # we failed, but migration was cancelled in the meantime
Line 348:                     # so don't try again
Line 349:                     if self._migrationCanceledEvt:
Line 350:                         break


-- 
To view, visit https://gerrit.ovirt.org/45954
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8952f732033ed160292b11fbc0c4deac099b2b3e
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list