Change in vdsm[master]: asyncore: use default handing of read event

Yaniv Bronhaim gerrit2 at gerrit.ovirt.org
Mon Oct 5 08:40:54 UTC 2015


Yaniv Bronhaim has posted comments on this change.

Change subject: asyncore: use default handing of read event
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/46911/2//COMMIT_MSG
Commit Message:

Line 9: It seems that we provided our own handle_read_event method due to
Line 10: assumption that we need to distinguish between fds which support
Line 11: pending and not. There are two fd types which do not provide pending
Line 12: method: plain socket and AsyncoreEvent which uses EventFD. Only our
Line 13: implementations of sslsocket provide pending.
and where is this being handled? seems like we used here eventfds in the past, where was it changed?
Line 14: 
Line 15: Default implementation do not care about it because it is not using
Line 16: pending and after several iteration of testing it seems to be OK.
Line 17: 


-- 
To view, visit https://gerrit.ovirt.org/46911
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4dd6856f5c08da459478c60ac1fe7881baa69a2
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list