Change in vdsm[master]: jsonrpc: ignore unknown message id

Yaniv Bronhaim gerrit2 at gerrit.ovirt.org
Mon Oct 5 08:28:48 UTC 2015


Yaniv Bronhaim has posted comments on this change.

Change subject: jsonrpc: ignore unknown message id
......................................................................


Patch Set 4:

(2 comments)

https://gerrit.ovirt.org/#/c/43746/4//COMMIT_MSG
Commit Message:

Line 8: 
Line 9: When we received jsonrpc request which is missing an id we need to make sure
Line 10: that we are able to ignore it without blowing up. Current client code base
Line 11: will make sure that requests have ids at all times but we need to cover edge
Line 12: cases like this since we have mini broker capabilities and any client could be
pass 80 characters
Line 13: used.
Line 14: 
Line 15: 
Line 16: Change-Id: Ide306f44c8c42d6661932698307efa4ce163e90e


Line 9: When we received jsonrpc request which is missing an id we need to make sure
Line 10: that we are able to ignore it without blowing up. Current client code base
Line 11: will make sure that requests have ids at all times but we need to cover edge
Line 12: cases like this since we have mini broker capabilities and any client could be
Line 13: used.
if we ignore clients that don't use id. don't we need to report it in some way?
Line 14: 
Line 15: 
Line 16: Change-Id: Ide306f44c8c42d6661932698307efa4ce163e90e


-- 
To view, visit https://gerrit.ovirt.org/43746
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ide306f44c8c42d6661932698307efa4ce163e90e
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dmitrykuzn at gmail.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list