Change in vdsm[master]: test: moving getInstance to its class

piotr.kliczewski at gmail.com piotr.kliczewski at gmail.com
Fri Oct 2 14:53:24 UTC 2015


Piotr Kliczewski has posted comments on this change.

Change subject: test: moving getInstance to its class
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/46941/1/tests/integration/jsonRpcHelper.py
File tests/integration/jsonRpcHelper.py:

Line 59:         API.StorageDomain.BLANK_UUID = '00000000-0000-0000-0000-000000000000'
Line 60:         API.Volume.BLANK_UUID = "00000000-0000-0000-0000-000000000000"
Line 61: 
Line 62:     def getInstance(self):
Line 63:         return FakeClientIf()
> good idea. Please note that this does a quite different thing with respect 
It was never meant to be singleton. It is a method which returns instance of FakeClientIf for mocking. There is no other reason to have it. Will add docstring.
Line 64: 
Line 65:     @property
Line 66:     def ready(self):
Line 67:         return True


-- 
To view, visit https://gerrit.ovirt.org/46941
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iadc44aef17d1ebcf8b6b7b63fce3fa8d34b4c0a3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list