Change in vdsm[master]: sampling: move translation code into hoststats.py

rmohr at redhat.com rmohr at redhat.com
Fri Oct 2 12:17:09 UTC 2015


Roman Mohr has posted comments on this change.

Change subject: sampling: move translation code into hoststats.py
......................................................................


Patch Set 13:

(2 comments)

https://gerrit.ovirt.org/#/c/42034/13//COMMIT_MSG
Commit Message:

Line 14: getBootTime() and get_boot_time() were moved
       : as well, even though they aren't translation
       : functions. Should they stay into sampling.py?
It probably should be in sampling.py when looking into the files, but just from the file names I would have expected it in hoststats.py.


https://gerrit.ovirt.org/#/c/42034/13/vdsm/virt/hoststats.py
File vdsm/virt/hoststats.py:

Line 86: self._boot_time():
       :         stats['bootTime'] = self._boot_time()
_boot_time()


-- 
To view, visit https://gerrit.ovirt.org/42034
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icce6acbd596d087491678d039282d5d37d761904
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list