Change in vdsm[master]: sampling: move translation code into hoststats.py
rmohr at redhat.com
rmohr at redhat.com
Fri Oct 2 12:00:44 UTC 2015
Roman Mohr has posted comments on this change.
Change subject: sampling: move translation code into hoststats.py
......................................................................
Patch Set 13:
(6 comments)
https://gerrit.ovirt.org/#/c/42034/13//COMMIT_MSG
Commit Message:
Line 9: produces
produce
https://gerrit.ovirt.org/#/c/42034/13/tests/hoststatsTests.py
File tests/hoststatsTests.py:
Line 20:
: from contextlib import contextmanager
: import itertools
: import os
: import tempfile
: import random
: import shutil
: import threading
:
: from vdsm import ipwrapper
: from vdsm.password import ProtectedPassword
: from virt import hoststats
: import virt.sampling as sampling
:
: import caps
:
: from testValidation import brokentest, ValidateRunningAsRoot
: from testlib import permutations, expandPermutations
: from testlib import VdsmTestCase as TestCaseBase
: from monkeypatch import MonkeyPatchScope
: from functional import dummy
: import vmfakelib as fake
unused imports
https://gerrit.ovirt.org/#/c/42034/13/tests/samplingTests.py
File tests/samplingTests.py:
Line 21: from contextlib import contextmanager
: import itertools
: import os
: import tempfile
: import random
: import shutil
: import threading
:
: from vdsm import ipwrapper
: from vdsm.password import ProtectedPassword
: import virt.sampling as sampling
:
: import caps
:
: from testValidation import brokentest, ValidateRunningAsRoot
: from testlib import permutations, expandPermutations
: from testlib import VdsmTestCase as TestCaseBase
: from monkeypatch import MonkeyPatchScope
: from nettestlib import dummy_device
: import vmfakelib as fake
there are unused imports, just run an import cleanup
https://gerrit.ovirt.org/#/c/42034/13/vdsm/virt/hoststats.py
File vdsm/virt/hoststats.py:
Line 72: self._ncpu
ncpus
Line 76: self._ncpus
ncpus
https://gerrit.ovirt.org/#/c/42034/13/vdsm/virt/sampling.py
File vdsm/virt/sampling.py:
Line 33: import six
unused import
--
To view, visit https://gerrit.ovirt.org/42034
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icce6acbd596d087491678d039282d5d37d761904
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list