Change in vdsm[ovirt-3.6]: automation: enable pep8

phoracek at redhat.com phoracek at redhat.com
Fri Oct 2 08:57:04 UTC 2015


Hello Piotr Kliczewski, Martin Sivák, Dan Kenigsberg, Francesco Romani,

I'd like you to do a code review.  Please visit

    https://gerrit.ovirt.org/46928

to review the following change.

Change subject: automation: enable pep8
......................................................................

automation: enable pep8

We now have a single check-patch job.

Change-Id: If2266725af30e45b414d040f7f8d6b47d46bf947
Bug-Url: https://bugzilla.redhat.com/1268229
Signed-off-by: Dan Kenigsberg <danken at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/45753
Continuous-Integration: Jenkins CI
Reviewed-by: Martin Sivák <msivak at redhat.com>
Reviewed-by: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Reviewed-by: Francesco Romani <fromani at redhat.com>
---
M automation/check-patch.sh
1 file changed, 0 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/28/46928/1

diff --git a/automation/check-patch.sh b/automation/check-patch.sh
index 51f7ee3..68a3083 100755
--- a/automation/check-patch.sh
+++ b/automation/check-patch.sh
@@ -10,8 +10,6 @@
 # this redefines 'ugly' but looks like NOSE_EXCLUDE works at test method level,
 # not at module neither at testcase level, so we have no choice but this.
 export NOSE_EXCLUDE=".*testGetBondingOptions.*|testMirroring.*|testToggleIngress|testException|testQdiscsOfDevice|testReplacePrio"
-# disable pep8 checks on unit test, since we have seperate job on it.
-export PEP8=$(which true)
 
 sh -x autogen.sh --system
 make all


-- 
To view, visit https://gerrit.ovirt.org/46928
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If2266725af30e45b414d040f7f8d6b47d46bf947
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>


More information about the vdsm-patches mailing list