Change in vdsm[master]: host stats: Add cpusStatus to vdsStats

fromani at redhat.com fromani at redhat.com
Fri Oct 2 07:53:09 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: host stats: Add cpusStatus to vdsStats
......................................................................


Patch Set 7: Code-Review+1

(1 comment)

https://gerrit.ovirt.org/#/c/46270/7/tests/samplingTests.py
File tests/samplingTests.py:

Line 271:             self._hs = sampling.HostStatsThread(self.log)
Line 272:             self.assertEquals(self._hs.get(), expected)
Line 273: 
Line 274:     def testCpusStatus(self):
Line 275:         cpusStatus = [True, False, True, False]
do we really need this temporary? Please inline it
Line 276: 
Line 277:         def get():
Line 278:             class LibvirtConnection(object):
Line 279:                 def getCPUMap(self):


-- 
To view, visit https://gerrit.ovirt.org/46270
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I73c92f563c7c3e8ffbbcf639eba27fbe55389994
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Roman Mohr <rmohr at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list