Change in vdsm[master]: networkTests: normalize strings (to unicode) through json magic

osvoboda at redhat.com osvoboda at redhat.com
Thu Oct 1 21:33:43 UTC 2015


Ondřej Svoboda has posted comments on this change.

Change subject: networkTests: normalize strings (to unicode) through json magic
......................................................................


Patch Set 6: Verified+1

Example output with iproute2 configurator (that really needs some love) is below.

It is clear that unicode vs. str is not the problem anymore: for even easier comparison I would welcome a comma and a newline after each dictionary record.

FAIL: testAddVlanedBridgeless (functional.networkTests.NetworkTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/share/vdsm/tests/functional/networkTests.py", line 221, in wrapper
    func(*args, **kwargs)
  File "/usr/share/vdsm/tests/functional/networkTests.py", line 1858, in testAddVlanedBridgeless
    {vlan_name: bridged}, {}, {})
  File "/usr/share/vdsm/tests/functional/networkTests.py", line 379, in setupNetworks
    self._assert_kernel_config_matches_running_config()
  File "/usr/share/vdsm/tests/functional/networkTests.py", line 395, in _assert_kernel_config_matches_running_config
    self.assertEqual(running_config['networks'], kernel_config['networks'])
AssertionError: {u'test-network-v': {u'vlan': u'27', u'nic': u'dummy_vJHWU', u'dhcpv6': False, u [truncated]... != {u'test-network-v'
: {u'dhcpv6': False, u'mtu': u'1500', u'bootproto': u'none', u [truncated]...
  {u'test-network': {u'bootproto': u'none',
                     u'bridged': False,
                     u'defaultRoute': False,
                     u'dhcpv6': False,
                     u'mtu': u'1500',
                     u'nic': u'dummy_vJHWU'},
   u'test-network-v': {u'bootproto': u'none',
                       u'bridged': True,
                       u'defaultRoute': False,
                       u'dhcpv6': False,
                       u'mtu': u'1500',
-                      u'nic': u'dummy_vJHWU',
-                      u'stp': False,
?                                   ^

+                      u'stp': False}}
?                                   ^^

-                      u'vlan': u'27'}}

-- 
To view, visit https://gerrit.ovirt.org/45201
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6362e04189f134ad27ee4e3c1991020b2eee91aa
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: No


More information about the vdsm-patches mailing list