Change in vdsm[master]: gluster: Add alerts when replica count is not 3
nsoffer at redhat.com
nsoffer at redhat.com
Mon Nov 30 23:00:06 UTC 2015
Nir Soffer has posted comments on this change.
Change subject: gluster: Add alerts when replica count is not 3
......................................................................
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/49475/1/vdsm/storage/hsm.py
File vdsm/storage/hsm.py:
Line 2503: res.append({'id': conDef["id"],
Line 2504: 'status': status,
Line 2505: 'alerts': conObj.getAlerts().info()})
Line 2506: else:
Line 2507: res.append({'id': conDef["id"], 'status': status})
> You are duplicating the response creation code.
This is a change in vdsm api, so it must be documented in the vdsm schema. Fill free to send separate schema patch to keep patches small and simple.
Line 2508:
Line 2509: # Connecting new device may change the visible storage domain list
Line 2510: # so invalidate caches
Line 2511: sdCache.invalidateStorage()
--
To view, visit https://gerrit.ovirt.org/49475
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I29023470a17c48d396cb58eec0660de7faba4ee0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list