Change in vdsm[master]: API: Add api for getting host jobs info

nsoffer at redhat.com nsoffer at redhat.com
Mon Nov 30 20:34:19 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: API: Add api for getting host jobs info
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/49451/1/lib/api/vdsmapi-schema.json
File lib/api/vdsmapi-schema.json:

Line 4173: # Since: 4.17.3
Line 4174: ##
Line 4175: {'command': {'class': 'Host', 'name': 'getJobs'},
Line 4176:  'data': {'*type_filter': 'HostJobType'},
Line 4177:  'returns': 'HostJobInfoMap'}
> But None is not usable via xmlrpc - if we want to keep xmlrpc, we need a su
We can also use empty string "" as the speical ANY value.

The code for both empty string and empty list is the same:

    if job_type:
        filter by job_type...

    if job_ids:
       filter by job_ids...
Line 4178: 
Line 4179: ##
Line 4180: # @Host.abortV2VJob:
Line 4181: #


-- 
To view, visit https://gerrit.ovirt.org/49451
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I957938ea9ca55d2499d09dfed39821c85e3e9d48
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list