Change in vdsm[master]: schema: introduce HostJobs basic types

nsoffer at redhat.com nsoffer at redhat.com
Mon Nov 30 19:42:23 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: schema: introduce HostJobs basic types
......................................................................


Patch Set 1: Code-Review-1

(4 comments)

Adam, can you answer the questions?

https://gerrit.ovirt.org/#/c/49450/1/lib/api/vdsmapi-schema.json
File lib/api/vdsmapi-schema.json:

Line 4086: # The execution state of a @HostJob.
Line 4087: #
Line 4088: # @running:  The job is executing
Line 4089: #
Line 4090: # @aborted:  The job is aborted by user request
was aborted
Line 4091: #
Line 4092: # @error:    The job has failed
Line 4093: #
Line 4094: # @done:     The job has finished successfully


Line 4106: # @generic:  A basic, untyped job
Line 4107: #
Line 4108: # Since: 4.17.3
Line 4109: ##
Line 4110: {'enum': 'HostJobType', 'data': ['generic']}
Why not 'storage', 'v2v', ... ?
Line 4111: 
Line 4112: ##
Line 4113: # @GenericHostJobInfo:
Line 4114: #


Line 4109: ##
Line 4110: {'enum': 'HostJobType', 'data': ['generic']}
Line 4111: 
Line 4112: ##
Line 4113: # @GenericHostJobInfo:
We don't need this type. Why not use the same HostJobInfo for alll types of jobs?

To support type specific info, we an add extra_info key, holding StorageJobInfo, V2VJobInfo, etc.
Line 4114: #
Line 4115: # HostJobInfo for generic job types.
Line 4116: #
Line 4117: # @id:           The job UUID


Line 4139: # @id:           The job UUID
Line 4140: #
Line 4141: # @description:  A free-form description of the job
Line 4142: #
Line 4143: # @progress:     Progress indication
(0-100)
Line 4144: #
Line 4145: # @job_type:     The specific job type
Line 4146: #
Line 4147: # Since: 4.17.3


-- 
To view, visit https://gerrit.ovirt.org/49450
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibedc242e22de0f3c69e722596a03fb0538594009
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list