Change in vdsm[master]: net: move tc library under lib/vdsm

osvoboda at redhat.com osvoboda at redhat.com
Mon Nov 30 18:24:03 UTC 2015


Ondřej Svoboda has posted comments on this change.

Change subject: net: move tc library under lib/vdsm
......................................................................


Patch Set 6: Code-Review-1

(5 comments)

Almost perfect!

https://gerrit.ovirt.org/#/c/49238/6//COMMIT_MSG
Commit Message:

Line 10: aplphabetical
alphabetical


Line 10: logic changed
change to logic?


https://gerrit.ovirt.org/#/c/49238/6/tests/functional/networkTests.py
File tests/functional/networkTests.py:

Line 47: api, errors, sourceroute
One line per module import.


https://gerrit.ovirt.org/#/c/49238/6/vdsm/caps.py
File vdsm/caps.py:

Line 38: tc
On its own line.


https://gerrit.ovirt.org/#/c/49238/6/vdsm/supervdsmServer
File vdsm/supervdsmServer:

Line 70: from vdsm.tc import setPortMirroring, unsetPortMirroring
This line could be moved further down.


-- 
To view, visit https://gerrit.ovirt.org/49238
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb4f8499b8ebaaf927aa2df36b4107bd943fc69c
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list