Change in vdsm[master]: net: split netinfo module

osvoboda at redhat.com osvoboda at redhat.com
Mon Nov 30 18:17:20 UTC 2015


Ondřej Svoboda has posted comments on this change.

Change subject: net: split netinfo module
......................................................................


Patch Set 11: Code-Review-1

(6 comments)

Comments for uniformity, I may be repeating what Petr wished for (this applies to all files):

I would like licence blocks to end with # and to be separated by an extra blank line. The Hat should be Red.

Imports should be sorted unless this means that git doesn't recognize where code comes from.

https://gerrit.ovirt.org/#/c/49198/11//COMMIT_MSG
Commit Message:

Line 10: fem
few


Line 12: easiyer
easier


https://gerrit.ovirt.org/#/c/49198/11/lib/vdsm/kernelconfig.py
File lib/vdsm/kernelconfig.py:

Line 25: bonding, bridges, addresses, mtus
Every module import should be on its own line.


https://gerrit.ovirt.org/#/c/49198/11/lib/vdsm/netinfo/Makefile.am
File lib/vdsm/netinfo/Makefile.am:

Line 2: Hat
Red Hat


https://gerrit.ovirt.org/#/c/49198/11/lib/vdsm/netinfo/__init__.py
File lib/vdsm/netinfo/__init__.py:

Line 19: from __future__ import absolute_import
In the case we needed to add a comment before imports, I would prefer to have a blank line after the license block so the comment blocks would not get mixed together.

The last line of the licence block can be just # to look tidy.


Line 23: import errno
Are you keeping the ordering the same as in netinfo.py so this file matched it better and git recognized it as a rename? In that case I don't object against imports not being sorted.


-- 
To view, visit https://gerrit.ovirt.org/49198
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I297b55f68f69c4ba0f1c854bcadddc087a2e9089
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list