Change in vdsm[master]: guestagent: Remove unneeded encoding

vfeenstr at redhat.com vfeenstr at redhat.com
Mon Nov 30 12:47:56 UTC 2015


Vinzenz Feenstra has posted comments on this change.

Change subject: guestagent: Remove unneeded encoding
......................................................................


Patch Set 1: -Code-Review

(1 comment)

https://gerrit.ovirt.org/#/c/49338/1/vdsm/virt/guestagent.py
File vdsm/virt/guestagent.py:

Line 238:         if ver > self.effectiveApiVersion:
Line 239:             raise GuestAgentUnsupportedMessage(cmd, ver,
Line 240:                                                self.effectiveApiVersion)
Line 241:         args['__name__'] = cmd
Line 242:         message = json.dumps(args) + '\n'
> is the output of json.dumps() consumable by _sock.send() also on Python3?
no it is not

>>> s.send(json.dumps({u'abc': 'whatever'}))
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
TypeError: 'str' does not support the buffer interface
Line 243:         self._sock.send(message)
Line 244:         self.log.log(logging.TRACE, 'sent %s', message)
Line 245: 
Line 246:     def _handleMessage(self, message, args):


-- 
To view, visit https://gerrit.ovirt.org/49338
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I95e0875d6a2428714e9d979cb9db34a6399f4623
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list