Change in vdsm[master]: vm: check operation result for vm nic hotunplug
danken at redhat.com
danken at redhat.com
Sun Nov 29 20:23:39 UTC 2015
Dan Kenigsberg has posted comments on this change.
Change subject: vm: check operation result for vm nic hotunplug
......................................................................
Patch Set 16: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/48473/16/vdsm/virt/vmdevices/network.py
File vdsm/virt/vmdevices/network.py:
Line 194: The path is relative to the root element
Line 195: """
Line 196: return "./devices/interface/mac[@address='%s']" % self.macAddr
Line 197:
Line 198: def _make_name(self):
> OK, so we should fix the tests, in a later patch.
We should not introduce an obscure complexity into the already-overcomplex vmcreate flow just because a test does not provide libvirt's alias to the Interface object.
Which tests fail due to this? I'd rather have them fixed now, or at the very least - marked with a #TODO.
Line 199: """
Line 200: Creates an interface name if one was not set.
Line 201: There is no guarantee that the interface name will be set in
Line 202: constructor, so we need this to make sure we have a value for name.
--
To view, visit https://gerrit.ovirt.org/48473
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3d3b2c839cbb4733aecc8d5a0e9a1ae691e14ac3
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki <mmirecki at redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list