Change in vdsm[master]: Add environment variable to scan alignment calls

nsoffer at redhat.com nsoffer at redhat.com
Sun Nov 29 14:39:11 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: Add environment variable to scan alignment calls
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/40402/3/vdsm/alignmentScan.py
File vdsm/alignmentScan.py:

Line 39: 
Line 40: def runScanArgs(*args):
Line 41:     cmd = [_virtAlignmentScan.cmd]
Line 42:     cmd.extend(args)
Line 43:     return execCmd(cmd, env={'LIBGUESTFS_BACKEND': 'direct'})
We are running this only when vm is down, isn't this safe enough?
Line 44: 
Line 45: 
Line 46: def scanImage(image_path):
Line 47:     image_path = image_path.strip()


-- 
To view, visit https://gerrit.ovirt.org/40402
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I00d8b681e4d2a2f4fb60e673eefdc807d8e1447d
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list