Change in vdsm[master]: build: Cleanup conditionals in the build system

nsoffer at redhat.com nsoffer at redhat.com
Sun Nov 29 00:29:00 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: build: Cleanup conditionals in the build system
......................................................................


Patch Set 19:

This is the configure line when using

   $ ./autogen.sh --system

The spec:

    %configure \                                                                                                                                                                
    %if 0%{?with_hooks}
            --enable-hooks \
    %endif
    %if ! 0%{?with_gluster_mgmt}
            --disable-gluster-mgmt \
    %endif
            --with-smbios-manufacturer='oVirt' \
            --with-smbios-osname='oVirt Node' \
            --with-qemu-kvm='qemu-kvm' \
            --with-qemu-img='qemu-img'

The internal %configure

+ ./configure --build=x86_64-redhat-linux-gnu --host=x86_64-redhat-linux-gnu --program-prefix= --disable-dependency-tracking --prefix=/usr --exec-prefix=/usr --bindir=/usr/bin --sbindir=/usr/sbin --sysconfdir=/etc --datadir=/usr/share --includedir=/usr/include --libdir=/usr/lib64 --libexecdir=/usr/libexec --localstatedir=/var --sharedstatedir=/var/lib --mandir=/usr/share/man --infodir=/usr/share/info --with-smbios-manufacturer=oVirt '--with-smbios-osname=oVirt Node' --with-qemu-kvm=qemu-kvm --with-qemu-img=qemu-img


Configuring for rhev:

    ./autogen.sh \
        --system \
        --enable-hooks \
        --disable-gluster-mgmt \
        --with-smbios-manufacturer='Red Hat' \
        --with-smbios-osname='RHEV Hypervisor' \
        --with-qemu-kvm='qemu-kvm-rhev' \
        --with-qemu-img='qemu-img-rhev'

The spec:

   %configure \                                                                                                                                                                
    %if 0%{?with_hooks}
            --enable-hooks \
    %endif
    %if ! 0%{?with_gluster_mgmt}
            --disable-gluster-mgmt \
    %endif
            --with-smbios-manufacturer='Red Hat' \
            --with-smbios-osname='RHEV Hypervisor' \
            --with-qemu-kvm='qemu-kvm-rhev' \
            --with-qemu-img='qemu-img-rhev'

The internal %configure

+ ./configure --build=x86_64-redhat-linux-gnu --host=x86_64-redhat-linux-gnu --program-prefix= --disable-dependency-tracking --prefix=/usr --exec-prefix=/usr --bindir=/usr/bin --sbindir=/usr/sbin --sysconfdir=/etc --datadir=/usr/share --includedir=/usr/include --libdir=/usr/lib64 --libexecdir=/usr/libexec --localstatedir=/var --sharedstatedir=/var/lib --mandir=/usr/share/man --infodir=/usr/share/info --enable-hooks --disable-gluster-mgmt '--with-smbios-manufacturer=Red Hat' '--with-smbios-osname=RHEV Hypervisor' --with-qemu-kvm=qemu-kvm-rhev --with-qemu-img=qemu-img-rhev

-- 
To view, visit https://gerrit.ovirt.org/48446
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9c94d206eb94ba51752423831ce4e01214a6a6d3
Gerrit-PatchSet: 19
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Barak Korren <bkorren at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: No


More information about the vdsm-patches mailing list