Change in vdsm[master]: guestagent: Log guest agent life cycle events

nsoffer at redhat.com nsoffer at redhat.com
Sat Nov 28 18:39:55 UTC 2015


Nir Soffer has uploaded a new change for review.

Change subject: guestagent: Log guest agent life cycle events
......................................................................

guestagent: Log guest agent life cycle events

GuestAgent is was not logging anything when starting or stopping, making
it harder to debug. To understand if a guest agent was stopped, one had
to look for ChanelListener debug message. Important events such as
starting and stopping a subsystem must be logged.

Change-Id: I4d6706e10d37a1268894185b08f59010c5e26850
Signed-off-by: Nir Soffer <nsoffer at redhat.com>
---
M vdsm/virt/guestagent.py
1 file changed, 2 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/41/49341/1

diff --git a/vdsm/virt/guestagent.py b/vdsm/virt/guestagent.py
index fb85b4a..d7c0d25 100644
--- a/vdsm/virt/guestagent.py
+++ b/vdsm/virt/guestagent.py
@@ -157,6 +157,7 @@
         return self._diskMappingHash
 
     def connect(self):
+        self.log.info("Starting connection")
         self._prepare_socket()
         self._channelListener.register(
             self._create,
@@ -332,6 +333,7 @@
             self.log.error('Unknown message type %s', message)
 
     def stop(self):
+        self.log.info("Stopping connection")
         self._stopped = True
         try:
             self._channelListener.unregister(self._sock.fileno())


-- 
To view, visit https://gerrit.ovirt.org/49341
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4d6706e10d37a1268894185b08f59010c5e26850
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>


More information about the vdsm-patches mailing list