Change in vdsm[master]: net: move tc library under lib/vdsm
phoracek at redhat.com
phoracek at redhat.com
Fri Nov 27 16:53:37 UTC 2015
Petr Horáček has posted comments on this change.
Change subject: net: move tc library under lib/vdsm
......................................................................
Patch Set 1: Code-Review-1
(3 comments)
https://gerrit.ovirt.org/#/c/49238/1//COMMIT_MSG
Commit Message:
Line 3: AuthorDate: 2015-11-26 13:42:27 +0200
Line 4: Commit: Ido Barkan <ibarkan at redhat.com>
Line 5: CommitDate: 2015-11-26 15:52:43 +0200
Line 6:
Line 7: net: move tc library under lib/vdsm
you could mention the imports refactoring you've done. i like those tiny improvements in importing, but it makes this patch a bit confusing and there is still lots of importing nonsense left. but i won't block this because of that.
Line 8:
Line 9: Change-Id: Ifb4f8499b8ebaaf927aa2df36b4107bd943fc69c
https://gerrit.ovirt.org/#/c/49238/1/lib/vdsm/tc/__init__.py
File lib/vdsm/tc/__init__.py:
Line 23: from functools import partial
Line 24: import errno
Line 25:
Line 26: from vdsm import ipwrapper
Line 27:
we should keep the line, dont we? to divide absolute and relative imports
Line 28: from . import filter as tc_filter
Line 29: from . import _parser
Line 30: from . import cls
Line 31: from . import qdisc
https://gerrit.ovirt.org/#/c/49238/1/vdsm/supervdsmServer
File vdsm/supervdsmServer:
Line 32
Line 33
Line 34
Line 35
Line 36
i think this should be kept
--
To view, visit https://gerrit.ovirt.org/49238
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb4f8499b8ebaaf927aa2df36b4107bd943fc69c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list