Change in vdsm[master]: automation: Eliminate unneeded variables

dcaro at redhat.com dcaro at redhat.com
Fri Nov 27 09:41:21 UTC 2015


David Caro has posted comments on this change.

Change subject: automation: Eliminate unneeded variables
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/49283/1/automation/check-patch.sh
File automation/check-patch.sh:

Line 13: # enable complex globs
Line 14: shopt -s extglob
Line 15: # if specfile was changed, try to install all created packages
Line 16: if git diff-tree --no-commit-id --name-only -r HEAD | grep --quiet 'vdsm.spec.in' ; then
Line 17:     yum -y install "$EXPORT_DIR/!(*.src).rpm"
the globs must go out of the quotes for them to work
Line 18: fi
Line 19: 
Line 20: # Generate coverage report in HTML format
Line 21: pushd tests


-- 
To view, visit https://gerrit.ovirt.org/49283
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8a3fd2149c52b0fbb5383c40a24447dc36808811
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: David Caro <dcaro at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list