Change in vdsm[master]: vm: check operation result for vm nic hotunplug

mmirecki at redhat.com mmirecki at redhat.com
Thu Nov 26 19:47:02 UTC 2015


Marcin Mirecki has posted comments on this change.

Change subject: vm: check operation result for vm nic hotunplug
......................................................................


Patch Set 13:

(2 comments)

https://gerrit.ovirt.org/#/c/48473/13/vdsm/virt/vmdevices/network.py
File vdsm/virt/vmdevices/network.py:

Line 42:             elif attr == 'network' and value == '':
Line 43:                 kwargs[attr] = DUMMY_BRIDGE
Line 44:         super(Interface, self).__init__(conf, log, **kwargs)
Line 45:         self.sndbufParam = False
Line 46:         self.name = self._make_name()
> What if name is already set? you just overwritten it with the default value
Done
Line 47:         self.is_hostdevice = self.device == hwclass.HOSTDEV
Line 48:         self.vlanId = self.specParams.get('vlanid')
Line 49:         self._customize()
Line 50: 


https://gerrit.ovirt.org/#/c/48473/13/vdsm/virt/vmdevices/storage.py
File vdsm/virt/vmdevices/storage.py:

Line 432:         source_key = {DISK_TYPE.FILE: 'file',
Line 433:                       DISK_TYPE.BLOCK: 'dev',
Line 434:                       DISK_TYPE.NETWORK: 'name'}
Line 435:         return "./devices/disk/source[@%s='%s']" \
Line 436:                % (source_key[self.diskType], self.path)
> Please replace the \ here with () - not in the next patch.
Done
Line 437: 
Line 438: 
Line 439: def _getSourceXML(drive):
Line 440:     source = vmxml.Element('source')


-- 
To view, visit https://gerrit.ovirt.org/48473
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3d3b2c839cbb4733aecc8d5a0e9a1ae691e14ac3
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki <mmirecki at redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list