Change in vdsm[master]: tests: proper cleanup in periodic tests

fromani at redhat.com fromani at redhat.com
Thu Nov 26 16:34:10 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: tests: proper cleanup in periodic tests
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/47249/3/tests/periodicTests.py
File tests/periodicTests.py:

Line 54:                                      scheduler=self.sched)
Line 55:         self.exc.start()
Line 56: 
Line 57:     def tearDown(self):
Line 58:         self.exc.stop()
> Lets use wait=True to make our intent more clear.
Done
Line 59:         self.exc = None
Line 60: 
Line 61:         self.sched.stop()
Line 62:         self.sched = None


-- 
To view, visit https://gerrit.ovirt.org/47249
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If07198bb368f79ace4b944612c71ee135c4458de
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list