Change in vdsm[master]: vm: check operation result for vm nic hotunplug

nsoffer at redhat.com nsoffer at redhat.com
Thu Nov 26 16:07:31 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: vm: check operation result for vm nic hotunplug
......................................................................


Patch Set 13: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/48473/13/vdsm/virt/vmdevices/network.py
File vdsm/virt/vmdevices/network.py:

Line 42:             elif attr == 'network' and value == '':
Line 43:                 kwargs[attr] = DUMMY_BRIDGE
Line 44:         super(Interface, self).__init__(conf, log, **kwargs)
Line 45:         self.sndbufParam = False
Line 46:         self.name = self._make_name()
What if name is already set? you just overwritten it with the default value

This should be something like:

    if not hasattr(self, 'name'):
        self.name = self._make_name()

This will be good enough for now.

The real solution is to have a proper default value mechanism for all attributes that may be unspecified.
Line 47:         self.is_hostdevice = self.device == hwclass.HOSTDEV
Line 48:         self.vlanId = self.specParams.get('vlanid')
Line 49:         self._customize()
Line 50: 


-- 
To view, visit https://gerrit.ovirt.org/48473
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3d3b2c839cbb4733aecc8d5a0e9a1ae691e14ac3
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki <mmirecki at redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list