Change in vdsm[master]: mkimage: setup right permissions before mkisofs

fromani at redhat.com fromani at redhat.com
Thu Nov 26 14:43:34 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: mkimage: setup right permissions before mkisofs
......................................................................


Patch Set 5:

(1 comment)

https://gerrit.ovirt.org/#/c/48538/5/vdsm/mkimage.py
File vdsm/mkimage.py:

Line 133:         # mkisofs/genisoimage will truncate the content and keep the
Line 134:         # permissions.
Line 135: 
Line 136:         if os.path.exists(isopath):
Line 137:             logging.warning("iso file %s exists, removing", isopath)
> Can you use %r ? This make it possible to detect leading and trailing white
Done
Line 138:             rmFile(isopath)
Line 139: 
Line 140:         fd = os.open(isopath, os.O_CREAT | os.O_RDONLY | os.O_EXCL, 0o640)
Line 141:         os.close(fd)


-- 
To view, visit https://gerrit.ovirt.org/48538
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc971a39ae2a8eaf7af934bb0922647e4676d03f
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list