Change in vdsm[master]: stomp: improve message id handling during response send

fromani at redhat.com fromani at redhat.com
Thu Nov 26 14:30:17 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: stomp: improve message id handling during response send
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

-1 for visibility and for a comment, besides that looks fine to me.

https://gerrit.ovirt.org/#/c/49185/1/lib/yajsonrpc/stompreactor.py
File lib/yajsonrpc/stompreactor.py:

Line 334:                 pass
Line 335:             try:
Line 336:                 del self._req_dest[response_id]
Line 337:             except KeyError:
Line 338:                 self.log.warn("Response to a message with id %s was not found",
let's use warning() and not warn()
Line 339:                               response_id)
Line 340: 
Line 341:         try:
Line 342:             connections = self._sub_map[destination]


-- 
To view, visit https://gerrit.ovirt.org/49185
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I21102b03245da7906d5618ba9e0f9811e8864c34
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list