Change in vdsm[master]: vm: unit test for vm._waitForDriveRemoval

fromani at redhat.com fromani at redhat.com
Thu Nov 26 14:12:19 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: vm: unit test for vm._waitForDriveRemoval
......................................................................


Patch Set 7:

(1 comment)

https://gerrit.ovirt.org/#/c/48880/7/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 2682:         self.log.debug("Waiting for hotunplug to finish")
Line 2683:         with utils.stopwatch("Hotunplug disk %s" % drive.name):
Line 2684:             deadline = (utils.monotonic_time() +
Line 2685:                         config.getfloat('vars', 'hotunplug_timeout'))
Line 2686:             sleep_time = config.getfloat('vars', 'hotunplug_check_interval')
not really sure this makes sense as float. OK, it is supported as float, but I can't see an use case to wait, leike, 1.5s or 0.723s.
Not very important, however.
Line 2687:             while self._isDriveAttached(drive):
Line 2688:                 time.sleep(sleep_time)
Line 2689:                 if utils.monotonic_time() > deadline:
Line 2690:                     raise HotunplugTimeout("Timeout detaching drive %s"


-- 
To view, visit https://gerrit.ovirt.org/48880
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4d1f86e17132a7099f109a5e33407c56dde40df2
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki <mmirecki at redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list