Change in vdsm[master]: v2v: externalVMList Xen+Kvm support

nsoffer at redhat.com nsoffer at redhat.com
Thu Nov 26 13:37:30 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: v2v: externalVMList Xen+Kvm support
......................................................................


Patch Set 6:

(1 comment)

https://gerrit.ovirt.org/#/c/48672/6//COMMIT_MSG
Commit Message:

Line 9: Not all new methods are supported in older version of libvirt under RHEL
Line 10: 5.x-7.x.
Line 11: We want to use one verb to probe VMs information from Xen, KVM and
Line 12: vCenter, as well as old libvirt versions.
Line 13: Tested with RHEL 5.x and above.
What are thed disadvantages of using the old apis compared with the new apis?

Can we use the old apis as a fallback if the new apis is not supported? Trypically libvirt will fail with UNSUPPORTED error code when the api you try to use is not supported.

See this for example of a fallback:
https://github.com/oVirt/vdsm/blob/master/vdsm/virt/vm.py#L3388

If there is no advantage using the new api, (only more convenient), this approach is fine. If using old apis brings with it other issues, I would try use the new api if possible.

Please consult with libvirt folks about this. The example fallback was suggested by Eric Blake.
Line 14: 
Line 15: Currently we externalVMList tested only with vCenter:
Line 16: vpx://...
Line 17: 


-- 
To view, visit https://gerrit.ovirt.org/48672
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic7d7e211a9343a528f260da2686b34cea00c53a4
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list