Change in vdsm[ovirt-3.6]: gluster: Remove duplicate servers
ahino at redhat.com
ahino at redhat.com
Thu Nov 26 11:56:59 UTC 2015
Ala Hino has posted comments on this change.
Change subject: gluster: Remove duplicate servers
......................................................................
Patch Set 3:
(2 comments)
https://gerrit.ovirt.org/#/c/49217/3/lib/vdsm/utils.py
File lib/vdsm/utils.py:
Line 1287: pass
Line 1288: else:
Line 1289: raise
Line 1290: if pid_file is not None:
Line 1291: rmFile(pid_file)
> Ala, this is not part of your patch, please kill and remove it.
Done
Line 1292:
Line 1293:
Line 1294: def unique(iterable):
Line 1295: """
https://gerrit.ovirt.org/#/c/49217/3/tests/storageServerTests.py
File tests/storageServerTests.py:
Line 170: @MonkeyPatch(storageServer, 'supervdsm', FakeSupervdsm())
Line 171: def test_duplicate_servers_in_volinfo(self):
Line 172: """
Line 173: This test simulates a use case where gluster server provided in the
Line 174: path doesn't appear in the volume info.
> Please send another patch fixing this wrong docstring.
Good catch; will fix it
Line 175: """
Line 176: def glusterVolumeInfo(volname=None, volfileServer=None):
Line 177: return {'music': {'brickCount': '3',
Line 178: 'bricks': ['192.168.122.5:/tmp/music',
--
To view, visit https://gerrit.ovirt.org/49217
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I10fd0c985e7fe024460faa288fc790e761da4811
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list