Change in vdsm[master]: build: Cleanup conditionals in the build system

piotr.kliczewski at gmail.com piotr.kliczewski at gmail.com
Thu Nov 26 08:19:04 UTC 2015


Piotr Kliczewski has posted comments on this change.

Change subject: build: Cleanup conditionals in the build system
......................................................................


Patch Set 18:

(1 comment)

https://gerrit.ovirt.org/#/c/48446/18/vdsm.spec.in
File vdsm.spec.in:

Line 10: %global snlk_user @SNLKUSER@
Line 11: %global cdrom_group @CDROMGROUP@
Line 12: 
Line 13: # Build types
Line 14: %global koji_build @KOJI_BUILD@
> no.. this variable just says if to install vhostmd or not and nothing else.
So if it "says if to install vhostmd" why the name do not reflect its intentions?
Line 15: 
Line 16: # Features
Line 17: %global with_gluster_mgmt @GLUSTER_MGMT@
Line 18: %global with_hooks @HOOKS@


-- 
To view, visit https://gerrit.ovirt.org/48446
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9c94d206eb94ba51752423831ce4e01214a6a6d3
Gerrit-PatchSet: 18
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Barak Korren <bkorren at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list