Change in vdsm[master]: vm: check operation result for vm nic hotunplug

nsoffer at redhat.com nsoffer at redhat.com
Wed Nov 25 17:12:57 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: vm: check operation result for vm nic hotunplug
......................................................................


Patch Set 9:

(1 comment)

https://gerrit.ovirt.org/#/c/48473/9/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 2691:             while self._isDriveAttached(device):
Line 2692:                 time.sleep(sleep_time)
Line 2693:                 if utils.monotonic_time() > deadline:
Line 2694:                     raise HotunplugTimeout("Timeout detaching device %s"
Line 2695:                                            % device.name)
> why is this rename useful?
We support any device now?
Line 2696: 
Line 2697:     def _isDriveAttached(self, device):
Line 2698:         root = ET.fromstring(self._dom.XMLDesc(0))
Line 2699:         return bool(root.findall(device.xpath))


-- 
To view, visit https://gerrit.ovirt.org/48473
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3d3b2c839cbb4733aecc8d5a0e9a1ae691e14ac3
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki <mmirecki at redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list