Change in vdsm[master]: code coverage: change approach how to enable it

nsoffer at redhat.com nsoffer at redhat.com
Wed Nov 25 16:44:26 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: code coverage: change approach how to enable it
......................................................................


Patch Set 2:

(2 comments)

Thanks Petr!

Looks good, please see the comments.

https://gerrit.ovirt.org/#/c/49168/2/lib/vdsm/config.py.in
File lib/vdsm/config.py.in:

Line 406: 
Line 407:         ('coverage_enable', 'false',
Line 408:             'Enable code coverage (requires python-coverage package). '
Line 409:             'false by default. Use environment file /etc/sysconfig/vdsm to '
Line 410:             'set COVERAGE_PROCESS_START and COVERAGE_FILE variables.'),
So you will install these files on all qe hosts, and then enable coverage via the configuration?

To make it easier for everyone, do you want to submit also this file to contrib/coverage.sample? (in another patch)
Line 411: 
Line 412:     ]),
Line 413: 
Line 414:     # Section: [gluster]


https://gerrit.ovirt.org/#/c/49168/2/vdsm/vdsm
File vdsm/vdsm:

Line 124:     logging.addLevelName(5, 'TRACE')
Line 125:     logging.TRACE = 5  # impolite but helpful
Line 126: 
Line 127:     # Used to enable code coverage. To enable it use coverage_enable option in
Line 128:     # devel section.
The comment is not needed, the line getting the configuration from the config explains itself.
Line 129:     if config.getboolean('devel', 'coverage_enable'):
Line 130:         import coverage
Line 131:         coverage.process_startup()
Line 132: 


-- 
To view, visit https://gerrit.ovirt.org/49168
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I49d8de0fd7c329d19a80827a4c2fd26eb70e04be
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Balogh <pbalogh at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list